Merged
Conversation
tompng
reviewed
Jul 11, 2024
8322136 to
515d67c
Compare
tompng
approved these changes
Jul 16, 2024
Member
tompng
left a comment
There was a problem hiding this comment.
I personally like def self.f syntax, especially when a module only have singleton methods.
Eexample: IRB::NestingParser and IRB::RubyLex (RubyLex does not have a state and it can be a module).
But yes, unifying the style has huge benefit 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think in most cases
class << selfmakes class methods easier to identify and locate because they'd fall under the same block and have another level of indentation. I also reorganized the constants/methods underRubyLex.