Change default completor from regexp to type-completor if RUBY_VERSION>=3.4#1010
Merged
tompng merged 1 commit intoruby:masterfrom Oct 6, 2024
Merged
Change default completor from regexp to type-completor if RUBY_VERSION>=3.4#1010tompng merged 1 commit intoruby:masterfrom
tompng merged 1 commit intoruby:masterfrom
Conversation
c0d6a80 to
1795ad5
Compare
Member
|
Since IMO the right solution here is to propose making |
…allback to RegexpCompletor.
1795ad5 to
d439875
Compare
Member
Author
|
ReplTypeCompletor is added to bundled gem now 🎉 I updated the pull request description.
Looks nice, added |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Oct 6, 2024
TypeCompletor and fallback to RegexpCompletor. (ruby/irb#1010) ruby/irb@bb6a99d815
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ruby >= 3.4, ReplTypeCompletor is a bundled gem, installed by default.
This pull request changes the default completor to type-completor if
RUBY_VERSION >= 3.4.If ReplTypeCompletor is not available (not installed or not added to Gemfile), fallbacks to regexp-baased completion.
The default isstill :regexp if
RUBY_VERSION < 3.4Run with bundler
With bundler and when repl_type_completor is not added to Gemfile, IRB will use regexp-based completion.
IRB shows warning message only If
--type-completororIRB.conf[:COMPLETOR] = :typeis explicitly specified.Restriction with rdbg
ReplTypeCompletor uses background thread to load RBS type information which could take time.
Debug gem stops all other threads, so if IRB enters debug mode before loading RBS completes, type completor can't use type information.
Even without type information, type completor can still complete as good or better than regexp-based completion.