Remove KEYWORD_ALIASES which handled special alias name of irb_break irb_catch and irb_next command#1004
Merged
tompng merged 2 commits intoruby:masterfrom Sep 12, 2024
Conversation
…irb_catch and irb_next command
Closed
st0012
approved these changes
Sep 12, 2024
Member
st0012
left a comment
There was a problem hiding this comment.
Good catch 👍 Just a small suggestion.
Co-authored-by: Stan Lo <stan001212@gmail.com>
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 12, 2024
of irb_break irb_catch and irb_next command (ruby/irb#1004) * Remove KEYWORD_ALIASES which handled special alias name of irb_break irb_catch and irb_next command * Remove unused instance variable user_aliases Co-authored-by: Stan Lo <stan001212@gmail.com> --------- ruby/irb@f256d7899f Co-authored-by: Stan Lo <stan001212@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comment is outdated. We don't need KEYWORD_ALIASES anymore.
[:catch, OVERRIDE_PRIVATE_ONLY]
Just like
exitandexit!,catchis already defined as a private method of Object.IRB's command usually sets OVERRIDE_PRIVATE_ONLY in this case.
[:next , OVERRIDE_ALL], [:break , OVERRIDE_ALL]
both
next abreak aare always syntax error. These input should be always treated as a command even if a method with the same name is defined.