Check if the file descriptor really exists#42
Merged
rtomayko merged 2 commits intortomayko:masterfrom Dec 5, 2013
TwP:master
Merged
Check if the file descriptor really exists#42rtomayko merged 2 commits intortomayko:masterfrom TwP:master
rtomayko merged 2 commits intortomayko:masterfrom
TwP:master
Conversation
If one of the `IO.pipe` calls fail, then the subsequent file descriptors will not be allocated. We need to account for this failure mode in the `ensure` block; otherwise the real error will be masked by an "undefined method on Nil" exception.
rtomayko
added a commit
that referenced
this pull request
Dec 5, 2013
Check if the file descriptor really exists
Owner
|
Merged and the 0.3.8 release should be on rubygems.org. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one of the
IO.pipecalls fail, then the subsequent file descriptors will not be allocated. We need to account for this failure mode in theensureblock; otherwise the real error will be masked by an "undefined method on Nil" exception./cc @rtomayko