fix(hook): use POSIX character classes for portable grep matching#98
Merged
pszymkowiak merged 1 commit intortk-ai:masterfrom Feb 13, 2026
Merged
Conversation
…ibility Replace \s with [[:space:]] in all grep -E patterns. The \s shorthand is a PCRE extension not guaranteed by POSIX ERE, causing intermittent match failures on macOS depending on grep version and locale settings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
FlorianBruniaux
added a commit
to FlorianBruniaux/rtk
that referenced
this pull request
Feb 14, 2026
Resolved conflicts: - Version bumped to 0.15.4 (Cargo.toml, Cargo.lock, .release-please-manifest.json) - CHANGELOG.md: Added upstream releases (0.15.4, 0.15.3, 0.15.2) - Hooks: Adopted POSIX character classes ([[:space:]]) from upstream - src/parser/mod.rs: Added multibyte UTF-8 tests from upstream - src/ruff_cmd.rs: Kept functions public for lint/format dispatcher feature Upstream changes integrated: - rtk-ai#120: git status fix for non-repo folders - rtk-ai#93: UTF-8 panic prevention on multibyte chars - rtk-ai#98: POSIX grep compatibility in hooks - rtk-ai#95, rtk-ai#92: CI reliability and hook coverage improvements Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ahundt
pushed a commit
to ahundt/rtk
that referenced
this pull request
Feb 23, 2026
…ibility (rtk-ai#98) Replace \s with [[:space:]] in all grep -E patterns. The \s shorthand is a PCRE extension not guaranteed by POSIX ERE, causing intermittent match failures on macOS depending on grep version and locale settings. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\swith[[:space:]]in all 41grep -Epatterns inrtk-rewrite.sh\sis a PCRE extension not guaranteed by POSIX ERE, causing intermittent match failures on macOS depending on grep version and locale settingspytest,cargo test,git statusetc. silently passing through without rewrite on affected systemsTest plan
rtk-prefixed commands still skip rewrite🤖 Generated with Claude Code