Skip to content

feat: add support for yarn test (Vitest)#272

Open
dlmw wants to merge 1 commit intortk-ai:masterfrom
dlmw:feature/yarn-test
Open

feat: add support for yarn test (Vitest)#272
dlmw wants to merge 1 commit intortk-ai:masterfrom
dlmw:feature/yarn-test

Conversation

@dlmw
Copy link

@dlmw dlmw commented Feb 27, 2026

No description provided.

@pszymkowiak
Copy link
Collaborator

Hi, this PR has conflicts with master. Could you rebase on current master? Thanks!

@dlmw dlmw force-pushed the feature/yarn-test branch from 4c89ed1 to 3dc89a3 Compare March 2, 2026 15:00
@dlmw
Copy link
Author

dlmw commented Mar 2, 2026

Should be good now. Could you run the workflows, please?

@dlmw dlmw force-pushed the feature/yarn-test branch from 3dc89a3 to c4379db Compare March 3, 2026 14:00
@aeppling
Copy link
Contributor

aeppling commented Mar 3, 2026

Hello, this is valid but we're going to merge and release #241
which will change how you insert your rewrite cmd.

This will be available during this week.

I will notify you for this little change so we have no conflict then.

@aeppling aeppling added depends-on depends on another PR or awaiting changes labels Mar 3, 2026
@FlorianBruniaux
Copy link
Collaborator

Hi @ThomasHoussin, @dlmw, @denneulin! You've each opened yarn-related PRs (#317, #272, #226) that all create yarn_cmd.rs — they'll conflict with each other. Could you coordinate? @ThomasHoussin's #317 is the most comprehensive, so we're thinking of using it as the base. @dlmw, @denneulin — could you check if your specific additions (vitest support, workspace support) could be contributed to #317 instead, or if #317 already covers them?

@pszymkowiak
Copy link
Collaborator

Note: this PR adds rules to hooks/rtk-rewrite.sh, but since #241 (rtk rewrite), all rewrite logic lives in Rust (src/discover/rules.rs + src/discover/registry.rs). The bash hook now just calls rtk rewrite "$cmd".

Please remove the changes to rtk-rewrite.sh and add your yarn test patterns to rules.rs / registry.rs instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends-on depends on another PR or awaiting changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants