fix(git): support multiple -m flags in git commit#203
Merged
aeppling merged 1 commit intortk-ai:masterfrom Feb 19, 2026
Merged
Conversation
Collaborator
|
Thank you! The code looks great — String → Vec with build_commit_command() helper is the right approach. 6 solid tests. There's a merge conflict with master (likely from #194 which just landed). Could you rebase on master? The conflict should be straightforward. Once resolved, LGTM to merge. |
Change message from String to Vec<String> so Clap accepts repeated -m flags, matching native git behavior for multi-paragraph commits. Extract build_commit_command() for testability. Add 6 tests covering Clap parsing and command construction. Closes rtk-ai#202.
Contributor
Author
|
Rebased on master, conflict in |
Contributor
|
Ok for merge, cicd need to pass first |
Contributor
Author
|
@aeppling just a heads-up → CI/CD was already failing on previous merges: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message: Stringtomessage: Vec<String>in Clap definition so repeated-mflags are acceptedbuild_commit_command()helper for testabilityCloses #202
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo test --all(399 tests pass)rtk git commit -m "title" -m "body"produces multi-paragraph commit