fix: git branch creation silently swallowed by list mode#194
Merged
pszymkowiak merged 1 commit intortk-ai:masterfrom Feb 18, 2026
Merged
Conversation
`rtk git branch <name>` fell into the listing code path which injected `-a --no-color`, turning the creation into a pattern-filtered listing (silent no-op with exit 0). Detect positional args without list-mode flags and route them to direct passthrough so branch creation, including `git branch <name> <start-point>`, works correctly. Adds regression integration tests for both cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Thank you! This was a nasty silent bug — rtk git branch feature-x doing nothing and returning exit 0 is really bad for users and agents. The detection logic looks correct: positional args without list flags → creation passthrough, list flags → compact listing. I checked the edge case of --contains main and it's handled Good bonus adding std::process::exit() on failure and the two integration regression tests. LGTM, merging. |
2 tasks
heAdz0r
added a commit
to heAdz0r/rtk
that referenced
this pull request
Feb 28, 2026
Upstream 0.22.2 sync (all previously missing fixes verified applied): - fix(lint): propagate linter exit code (rtk-ai#207) — CI false-green fix - feat: add rtk wc command for compact word/line/byte counts (rtk-ai#175) - fix(playwright): JSON parser (specs layer) + binary resolution (rtk-ai#215) - fix(grep): propagate rg exit codes 1/2 (rtk-ai#227) - fix(git): branch creation not swallowed by list mode (rtk-ai#194) - fix(git): support multiple -m flags in git commit (rtk-ai#202) - fix(grep): BRE \| translation + strip -r flag (rtk-ai#206) - fix(gh): smart markdown body filter for issue/pr view (rtk-ai#214) - fix(gh): gh run view --log-failed flag passthrough (rtk-ai#159) - feat(docker): docker compose support (rtk-ai#110) - feat: hook audit mode (rtk-ai#151) - feat: tee raw output to file (rtk-ai#134) Version bump: 0.21.1-fork.19 → 0.22.2-fork.1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk git branch <name>silently succeeded but never created the branch. The command fell into the listing code path which injected-a --no-color, turning creation into a pattern-filtered listing (empty output, exit 0).git branch <name>andgit branch <name> <start-point>work correctly.src/git.rs— therun_branch()function logic and two new regression integration tests.Test plan
cargo fmt --all --checkpassescargo test --all— 378 tests pass--ignored):test_branch_creation_not_swallowedandtest_branch_creation_from_commitboth passrtk git branch test-branchcreates the branch,git branch --list test-branchconfirms it existsrtk git branch,rtk git branch -a) still works as before🤖 Generated with Claude Code