Merged
Conversation
Collaborator
Author
|
@homunkulus r+ |
Contributor
|
📌 Commit def4fc8 has been approved by |
Contributor
Contributor
|
☀️ Test successful - status-travis |
| //! The `app!` macro is documented [here]. | ||
| //! | ||
| //! [here]: https://docs.rs/cortex-m-rtfm-macros/0.2.0/cortex_m_rtfm_macros/fn.app.html | ||
| //! [here]: https://docs.rs/cortex-m-rtfm-macros/0.2.1/cortex_m_rtfm_macros/fn.app.html |
Contributor
There was a problem hiding this comment.
You bumped the version to 0.3.0 but this refers to 0.2.1
| [dependencies] | ||
| cortex-m = { git = "https://github.com/japaric/cortex-m" } | ||
| cortex-m = "0.4.0" | ||
| cortex-m-rtfm-macros = "0.3.0" |
Contributor
There was a problem hiding this comment.
Is it not possible to keep the path dependency? I think Cargo will automatically rewrite it and publish both crates together.
Collaborator
Author
There was a problem hiding this comment.
I can try that next time.
andrewgazelka
pushed a commit
to andrewgazelka/cortex-m-rtic
that referenced
this pull request
Nov 3, 2021
v0.4.0: with LLD support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.