Conversation
|
soft suggestion: It might be simpler for reviewers to see the addition of connect cloud support before posit cloud is removed. |
I think it probably wouldn't be that simple. Connect Cloud's implementation is going to look quite different from Cloud's. |
It was a weak suggestion. You're right that the client is going to be completely different. I was more interested in seeing the references to connect cloud, posit cloud, and shinyapps.io from elsewhere in the code. I thought that it would be useful to see the differences and similarities with all the implementations, but I'm speculating. If you think things are clear enough with this approach, no need to change. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for deploying to Posit Connect Cloud, allowing applications to be deployed to the new cloud-hosted service in addition to existing targets like shinyapps.io and on-premise Connect servers.
- Adds Posit Connect Cloud as a predefined server with URL and SSL certificate
- Implements a new client for Connect Cloud with content management API integration
- Adds OAuth Bearer token authentication support for Connect Cloud deployments
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| R/servers.R | Adds Connect Cloud server definition and detection functions |
| R/client.R | Routes Connect Cloud accounts to new client implementation |
| R/client-connectCloud.R | New client implementation for Connect Cloud API |
| R/http.R | Adds Bearer token authentication support |
| R/deployApp.R | Integrates Connect Cloud deployment workflow |
| R/bundlePackageRenv.R | Minor whitespace cleanup |
| inst/cert/api.connect.posit.cloud.pem | SSL certificate for Connect Cloud API |
| tests/testthat/test-*.R | Test coverage for new functionality |
| tests/testthat/_snaps/servers.md | Updated test snapshots |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 7624198.
use rsconnect-specific oauth client
…of the description
Updating the documentation with supported server info
graceful showLogs failure for connect cloud
don't call PATCH /contents on first deploy
handle 409 for pending deletion the same way as a 404
Co-authored-by: Aron Atkins <aron@gweep.net>
Co-authored-by: Aron Atkins <aron@gweep.net>
Rewording for logs when deploying an app
…sion pcc content deleted no new revision
Sending the appMode in the update requests for publishing to PCC
Resolves #1216.