handle 409 for pending deletion the same way as a 404#1238
Merged
Conversation
rodriin
approved these changes
Oct 22, 2025
Member
rodriin
left a comment
There was a problem hiding this comment.
Looks pretty straight forward, treating it as a 404 error.
aronatkins
approved these changes
Oct 23, 2025
aronatkins
reviewed
Oct 23, 2025
R/client-connectCloud.R
Outdated
| content <- withTokenRefreshRetry(PATCH_JSON, path, json) | ||
| content <- tryCatch( | ||
| withTokenRefreshRetry(PATCH_JSON, path, json), | ||
| rsconnect_http_409 = function(e) { |
Contributor
There was a problem hiding this comment.
Should this be err not e? Additionally, is it worth adding parent=err to the cli_abort()?
Member
Author
There was a problem hiding this comment.
Something about this wasn't working right... But today I realized I can make the check sooner in getContent instead. Seems to be working fine with that change.
karawoo
reviewed
Oct 23, 2025
karawoo
approved these changes
Oct 23, 2025
Contributor
karawoo
left a comment
There was a problem hiding this comment.
One question about the wording but otherwise lgtm. Tried it locally and saw this which seems correct:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we delete a piece of content, there's a ~5 minute window where the content hasn't been fully deleted. When that's the case, we're not able to redeploy to it - we want to present the user the same prompt as when their app has been fully deleted.
Resolves #1236.