Skip to content

feat: rebase and refine extension-alias error format#30

Merged
SoonIter merged 1 commit intomainfrom
extension-alias
Oct 21, 2024
Merged

feat: rebase and refine extension-alias error format#30
SoonIter merged 1 commit intomainfrom
extension-alias

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Oct 17, 2024

close #29

adopt beneficial changes from oxc

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #30 will not alter performance

Comparing extension-alias (ae343c1) with main (fffde99)

Summary

✅ 3 untouched benchmarks

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.89%. Comparing base (fffde99) to head (ae343c1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/file_system.rs 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   97.05%   96.89%   -0.16%     
==========================================
  Files          11       11              
  Lines        2373     2387      +14     
==========================================
+ Hits         2303     2313      +10     
- Misses         70       74       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SoonIter SoonIter requested a review from hardfist October 21, 2024 04:07
@SoonIter SoonIter merged commit 9a8a105 into main Oct 21, 2024
@SoonIter SoonIter deleted the extension-alias branch October 21, 2024 07:32
@SoonIter SoonIter mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: error message when using externsionAlias

2 participants