Conversation
CodSpeed Performance ReportMerging #21 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 97.04% 97.05%
=======================================
Files 11 11
Lines 2366 2373 +7
=======================================
+ Hits 2296 2303 +7
Misses 70 70 ☔ View full report in Codecov by Sentry. |
hardfist
approved these changes
Aug 30, 2024
Contributor
This was referenced Aug 30, 2024
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix resolve failed when contains symbol link
this regression is introduced by oxc-project/oxc-resolver#220, so this pr is actually revert of oxc-project/oxc-resolver#220
this pr also disable wasi support temporarily cause the current wasi support has problem for pnpm workspace and rspack doesn't support wasi yet.
/ ------------- failing test ---------------/
The test case is marked
failingas napi is building without"yarn_pnp"feature. If the feature is enabled, the test case will pass, we need to address the behavioral differences between pnp and non-pnp.enhanced-resolve could handle this correctly.
Related: web-infra-dev/rspack#7707.