Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the test configuration by removing a previously necessary workaround for color output. This change suggests that the underlying issue requiring the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes a workaround that disabled colors in the test environment by removing the NO_COLOR environment variable setting. While this is a good cleanup, it will likely cause some existing snapshot tests to fail because they do not account for the new color codes in the output. I have added a comment with specific details on the affected tests and how to resolve the issue.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e53b09e31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| process.env.NO_COLOR = '1'; | ||
|
|
||
| export default defineConfig({ |
There was a problem hiding this comment.
Keep NO_COLOR set for deterministic snapshot tests
Removing the NO_COLOR assignment makes test output depend on the caller’s terminal/color env, and tests/logger.test.ts still has snapshot assertions (should log error with stack correctly / should log error with cause correctly) that compare raw logger strings without stripAnsi; when FORCE_COLOR=1 (or another color-enabling setup) util.styleText adds ANSI escapes and these snapshots no longer match. Keeping NO_COLOR in test config (or stripping ANSI in those tests) avoids this environment-specific failure.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Removes a test-only environment-variable workaround (NO_COLOR) from the @rstest/core configuration, aligning behavior with the upstream change referenced in PR #60.
Changes:
- Remove
process.env.NO_COLOR = '1'fromrstest.config.tsso test output coloring behavior is no longer forcibly disabled by the repo config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| process.env.NO_COLOR = '1'; | ||
|
|
||
| export default defineConfig({ | ||
| globals: true, |
There was a problem hiding this comment.
Removing the NO_COLOR override can make snapshot expectations sensitive to whether ANSI styling is enabled in the test environment. In this repo, the logger error snapshots (e.g. logger.error(err) cases) don't strip ANSI codes, so if util.styleText starts emitting color again those snapshots can change. Consider either keeping the env override in test config, or updating the error snapshot assertions/setup to normalize/strip ANSI so snapshots remain deterministic across environments.
| globals: true, | |
| globals: true, | |
| env: { | |
| NO_COLOR: '1', | |
| }, |
close #60