Skip to content

test: revert color workaround from @rstest/core 0.8.1#60

Closed
fi3ework wants to merge 1 commit intorstackjs:mainfrom
fi3ework:1
Closed

test: revert color workaround from @rstest/core 0.8.1#60
fi3ework wants to merge 1 commit intorstackjs:mainfrom
fi3ework:1

Conversation

@fi3ework
Copy link
Copy Markdown
Member

@fi3ework fi3ework commented Feb 5, 2026 •
edited
Loading

revert color workaround from @rstest/core 0.8.1, just like before.

@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Feb 5, 2026

Summary of Changes

Hello @fi3ework, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previously implemented color workaround by upgrading the @rstest/core dependency to version 0.8.3. The update is expected to resolve the underlying color issue, making the manual NO_COLOR environment variable unnecessary. This change streamlines the project's configuration and ensures it benefits from the latest fixes and features of the testing framework, along with other cascading dependency updates.

Highlights

  • Dependency Update: The @rstest/core package has been updated from version 0.8.1 to 0.8.3 in package.json and pnpm-lock.yaml.
  • Workaround Reversion: The temporary color workaround, process.env.NO_COLOR = '1', has been removed from rstest.config.ts as it is no longer necessary with the updated @rstest/core.
  • Lockfile Synchronization: The pnpm-lock.yaml file has been comprehensively updated to reflect the new @rstest/core version and includes updates for various @rspack and @rsbuild related packages, ensuring dependency consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • package.json
    • Updated @rstest/core from ^0.8.1 to ^0.8.3 in devDependencies.
  • pnpm-lock.yaml
    • Updated the resolved version of @rstest/core from 0.8.1 to 0.8.3.
    • Added @rsbuild/core@1.7.3 to the package list.
    • Updated various @rspack/binding-* packages (e.g., darwin-arm64, darwin-x64, linux-arm64-gnu, etc.) from version 1.7.4 to 1.7.5.
    • Updated @rspack/binding from 1.7.4 to 1.7.5.
    • Updated @rspack/core from 1.7.4 to 1.7.5.
  • rstest.config.ts
    • Removed the line process.env.NO_COLOR = '1';.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @rstest/core dependency to version ^0.8.3 and removes the associated workaround for color output in tests. The changes are straightforward, correct, and align with the description. The update to package.json and the removal of the NO_COLOR environment variable in rstest.config.ts are appropriate. The pnpm-lock.yaml file has been updated accordingly. The changes are good to merge.

@fi3ework fi3ework mentioned this pull request Feb 5, 2026
Merged
4 tasks
@chenjiahan chenjiahan mentioned this pull request Mar 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fi3ework