Skip to content

feat: support overriding version in template#23

Merged
chenjiahan merged 1 commit intorstackjs:mainfrom
colinaaa:main
Jan 10, 2025
Merged

feat: support overriding version in template#23
chenjiahan merged 1 commit intorstackjs:mainfrom
colinaaa:main

Conversation

@colinaaa
Copy link
Copy Markdown
Contributor

Summary

Add a version option in function create to support overriding dependencies' versions.

Usage

This is useful for monorepo(like Rsbuild).

In rsbuild/packages/core/package.json:

{
  "name": "create-rsbuild",
  "devDependencies": {
    "@rsbuild/core": "workspace:^",
    "@rsbuild/plugin-react": "workspace:^"
  }
}

In rsbuild/packages/create-rsbuild/src/index.ts:

// ...
const { devDependencies } = require('../package.json')

await create({
  // ...
  version: devDependencies,
})

Then, the template-react-ts/package.json of Rsbuild can be written as:

{
  "name": "rsbuild-react-ts",
  "devDependencies": {
    "@rsbuild/core": "anything-you-want",
    "@rsbuild/plugin-react": "or just workspace:^"
  }
}

The version would be updated at runtime, so that the templates within create-rsbuild will be always up-to-date with @rsbuild/core and @rsbuild/plugin-react

Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit 181d9d1 into rstackjs:main Jan 10, 2025
@chenjiahan
Copy link
Copy Markdown
Member

Released: https://github.com/rspack-contrib/create-rstack/releases/tag/v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants