Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Implement RubyFeatures.distincts_kw_args_from_positional_hash?#535

Merged
JonRowe merged 1 commit into
rspec:mainfrom
casperisfine:distincts_kw_args_from_positional_hash
Feb 22, 2022
Merged

Implement RubyFeatures.distincts_kw_args_from_positional_hash?#535
JonRowe merged 1 commit into
rspec:mainfrom
casperisfine:distincts_kw_args_from_positional_hash

Conversation

@casperisfine

Copy link
Copy Markdown
Contributor

Extracted from: rspec/rspec-mocks#1461

cc @pirj

@pirj pirj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@JonRowe do you have any objections?

@pirj

pirj commented Feb 21, 2022

Copy link
Copy Markdown
Member

Please don't hesitate to rubocop:disable Metrics/ModuleLength for this class. Once we release RSpec 4, we should be back down under 100 lines.

@casperisfine casperisfine force-pushed the distincts_kw_args_from_positional_hash branch from 0bbcf0c to 4dbb378 Compare February 21, 2022 13:42
@casperisfine

Copy link
Copy Markdown
Contributor Author

Please don't hesitate to rubocop:disable Metrics/ModuleLength for this class.

Done.

I hate these Metrics/* cops so much...

@JonRowe JonRowe merged commit c12b425 into rspec:main Feb 22, 2022
JonRowe added a commit that referenced this pull request Feb 22, 2022
JonRowe pushed a commit that referenced this pull request Mar 7, 2022
Extracted from: rspec/rspec-mocks#1461

Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
JonRowe added a commit that referenced this pull request Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants