This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Squat on less of the user's method namespace.#459
Merged
myronmarston merged 1 commit intomasterfrom Nov 9, 2013
Merged
Conversation
RSpec::Mocks::ExampleMethods is mixed into a context where users freely define their own methods. As such, it's best to not define private helper methods as the user may inadvertently overwrite them. These methods were all stateless, anyway, so they work equally well as class methods and this creates less surface area for override problems.
Member
|
This seems like a positive change, although I would be surprised to see users running into conflicts with those names (grin). |
myronmarston
added a commit
that referenced
this pull request
Nov 9, 2013
Squat on less of the user's method namespace.
Member
Author
|
I would be, too. I'm also surprised that any users define |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSpec::Mocks::ExampleMethods is mixed into a context
where users freely define their own methods. As such,
it's best to not define private helper methods as the
user may inadvertently overwrite them. These methods
were all stateless, anyway, so they work equally well
as class methods and this creates less surface area
for override problems.