So I'm realizing that this is going a different direction then we did for the issue of expect { }.not_to raise_error(something_specific) being prone to false positives -- there we raise an error. It seems odd to raise for one form that's prone to false positives but warn for another.

I'm also realizing that we may have other places in the future where we realize that a particular use of matcher is prone to false positives and should be discouraged.

Given that, I'm thinking maybe we do the following:

• Move the config for this off of RaiseError and onto RSpec::Expectations.configuration, as I suggested below.
• Rename it to warn_about_possible_false_positives and use it for this and for any other future cases where there's a potential false positive situation.
• Update the raise_error logic for the negative case to align with this -- it should either warn (if the config is set) or allow the potential false positive.

Thoughts?

Yup, agree

This is changed as discussed, I'll tackle changing raise_error for the negative case in a separate PR

Woop fixed Rubocop

This should be good to go now?

Left a couple comments but they aren't super important. Feel free to merge w/o addressing them.

LGTM, merge when green.