My best interpretation of what the typings should look like after merge of #464#628
Closed
eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
Closed
My best interpretation of what the typings should look like after merge of #464#628eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
Conversation
Juice10
requested changes
Jul 13, 2021
Member
Juice10
left a comment
There was a problem hiding this comment.
LGTM, I added some suggestions to make the code a little more idiomatic and descriptive.
Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
YunFeng0817
pushed a commit
that referenced
this pull request
Jul 15, 2021
* My best interpretation of what the typings should look like after merge of #464 * Apply variable name changes as per Juice10 review Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com> * fix types Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would appreciate a review, I don't really have a good feeling for typescript typing.