Tests: don't delete style attributes in post-processing#468
Merged
Yuyz0112 merged 1 commit intorrweb-io:masterfrom Jan 31, 2021
Merged
Tests: don't delete style attributes in post-processing#468Yuyz0112 merged 1 commit intorrweb-io:masterfrom
Yuyz0112 merged 1 commit intorrweb-io:masterfrom
Conversation
Merged
…important part of the mutations These were removed in rrweb-io@8ed1c99 in order to smooth over differences in test environments so have maintained that by converting pixel values to 'Npx' (could also try rounding, but didn't attempt that)
13a18b5 to
75329df
Compare
eoghanmurray
added a commit
to statcounter/rrweb
that referenced
this pull request
Feb 3, 2021
…important part of the mutations (rrweb-io#468) These were removed in rrweb-io@8ed1c99 in order to smooth over differences in test environments so have maintained that by converting pixel values to 'Npx' (could also try rounding, but didn't attempt that)
eoghanmurray
added a commit
to statcounter/rrweb
that referenced
this pull request
Feb 22, 2021
…important part of the mutations (rrweb-io#468) These were removed in rrweb-io@8ed1c99 in order to smooth over differences in test environments so have maintained that by converting pixel values to 'Npx' (could also try rounding, but didn't attempt that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one had me stumped for a few days as I didn't realise the test results were post-processed.
Making a separate pull request, but will be basing #464 on this