Skip to content

feat: add an option to determine whether to pause CSS animation when playback is paused#428

Merged
Yuyz0112 merged 1 commit intorrweb-io:masterfrom
YunFeng0817:animation_pause_option
Nov 27, 2020
Merged

feat: add an option to determine whether to pause CSS animation when playback is paused#428
Yuyz0112 merged 1 commit intorrweb-io:masterfrom
YunFeng0817:animation_pause_option

Conversation

@YunFeng0817
Copy link
Member

set pauseAnimation to true by default

…playback is paused

set pauseAnimation to true by default
@Yuyz0112
Copy link
Member

Thanks!

@Yuyz0112 Yuyz0112 merged commit 658999c into rrweb-io:master Nov 27, 2020
@YunFeng0817 YunFeng0817 deleted the animation_pause_option branch November 27, 2020 08:18
Yuyz0112 pushed a commit that referenced this pull request Nov 27, 2020
…playback is paused (#428)

set pauseAnimation to true by default
Yuyz0112 pushed a commit that referenced this pull request Feb 6, 2021
…playback is paused (#428)

set pauseAnimation to true by default
Yuyz0112 added a commit that referenced this pull request Feb 10, 2021
* Impl record iframe

* iframe observe

* temp: add bundle file to git

* update bundle

* update with pick

* update bundle

* fix fragment map remove

* feat: add an option to determine whether to pause CSS animation when playback is paused (#428)

set pauseAnimation to true by default

* fix: elements would lose some states like scroll position because of "virtual parent" optimization (#427)

* fix: elements would lose some state like scroll position because of "virtual parent" optimization

* refactor: the bugfix code

bug: elements would lose some state like scroll position because of "virtual parent" optimization

* fix: an error occured at applyMutation(remove nodes part)

error message:
Uncaught (in promise) DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node

* pick fixes

* revert ignore file

* re-impl iframe record

* re-impl iframe replay

* code housekeeping

* move multi layer dimension calculation to replay side

* update test cases

* teardown test server

* upgrade rrweb-snapshot with iframe load timeout

Co-authored-by: Lucky Feng <yun.feng@smartx.com>
eoghanmurray pushed a commit to statcounter/rrweb that referenced this pull request Feb 22, 2021
* Impl record iframe

* iframe observe

* temp: add bundle file to git

* update bundle

* update with pick

* update bundle

* fix fragment map remove

* feat: add an option to determine whether to pause CSS animation when playback is paused (rrweb-io#428)

set pauseAnimation to true by default

* fix: elements would lose some states like scroll position because of "virtual parent" optimization (rrweb-io#427)

* fix: elements would lose some state like scroll position because of "virtual parent" optimization

* refactor: the bugfix code

bug: elements would lose some state like scroll position because of "virtual parent" optimization

* fix: an error occured at applyMutation(remove nodes part)

error message:
Uncaught (in promise) DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node

* pick fixes

* revert ignore file

* re-impl iframe record

* re-impl iframe replay

* code housekeeping

* move multi layer dimension calculation to replay side

* update test cases

* teardown test server

* upgrade rrweb-snapshot with iframe load timeout

Co-authored-by: Lucky Feng <yun.feng@smartx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants