Merged
Conversation
…easier to understand) in longer boolean expressions with &&
…limDOMOptions; take the opportunity to cleanup and merge code
🦋 Changeset detectedLatest commit: cfe1a23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
approved these changes
Nov 19, 2025
This was referenced Mar 23, 2026
pauldambra
added a commit
to PostHog/posthog-rrweb
that referenced
this pull request
Mar 24, 2026
## Adopt upstream PR [rrweb-io/rrweb#1758](rrweb-io/rrweb#1758) Extracts duplicate slimDOM default options into a shared `slimDOMDefaults()` function in `rrweb-snapshot`, replacing inline defaults in both `snapshot()` and `record()`. ### Changes - New exported `slimDOMDefaults()` function in `@posthog/rrweb-snapshot` - Both `snapshot()` and `record/index.ts` now use the shared function - Aligns both callsites on the same defaults (`headMetaAuthorship` and `headTitleMutations` conditional on `'all'` mode) - Replaces repeated `=== 'x' || === 'y'` checks with `.includes()` for readability - Replaces `readyState === 'interactive' || readyState === 'complete'` with `.includes()` check Part of the upstream adoption stack tracked in #147.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.