Fix that blob urls persist on the shared anchor element and can't be later modified#1467
Merged
Juice10 merged 2 commits intorrweb-io:masterfrom May 3, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: d4f3c77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
approved these changes
May 3, 2024
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 31, 2024
…later modified (rrweb-io#1467) * Fix that blob urls persist on the shared anchor element and can't be later modified * Create nervous-kiwis-nail.md
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Sep 6, 2024
Merges the following commits: * [Ensure there is separation of timestamps](rrweb-io#1455) * [perf(snapshot): avoid recreate element a every time](rrweb-io#1387) * [Fix that blob urls persist on the shared anchor element and can't be later modified](rrweb-io#1467) * [yarn format - prettier improvements & add .editorconfig](rrweb-io#1471) * [Fixup for background-clip replacement](rrweb-io#1476) * [Fix and test for bug](rrweb-io#1481)
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Oct 16, 2024
…later modified (rrweb-io#1467) * Fix that blob urls persist on the shared anchor element and can't be later modified * Create nervous-kiwis-nail.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in tests that have been added in snapshot.test.ts in #1239
This bug is in master since this morning after I merged #1467 and that PR could do with some additional scrutiny now.