protect against no parent node#1445
Merged
eoghanmurray merged 3 commits intorrweb-io:masterfrom Apr 10, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: cab53df The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 9, 2024
eoghanmurray
approved these changes
Apr 10, 2024
1 task
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Apr 17, 2024
## Summary Fix `.tagName` null access issue reported on [discord](https://discord.com/channels/1026884757667188757/1229747689353252875) via rrweb-io/rrweb#1445 highlight/rrweb#115 Closes HIG-4504 ## How did you test this change? reflame ## Are there any deployment considerations? changeset ## Does this work require review from our design team? no
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
* protect against a missing parent node during a mutation on an textNode
1 task
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 31, 2024
* protect against a missing parent node during a mutation on an textNode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parentNodedoes not always exist causing the issue described in PostHog/posthog#21447We should just protect against it not being there.
Looks like this broke in #1351 merged into the newest alpha-12 release