Chore: Make inject script more robust on repl & stream#1429
Merged
Conversation
🦋 Changeset detectedLatest commit: d474b3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eoghanmurray
approved these changes
Apr 5, 2024
1 task
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
* try/catch injection of recording script in rrweb repl and stream * Add empty changesets
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 31, 2024
* try/catch injection of recording script in rrweb repl and stream * Add empty changesets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fails sometimes for me on some websites.
I think mainly due to a redirect making the frame not available anymore.
So we add a try/catch around it to make sure it works fine in all situations.