Skip to content

fix: createImageBitmap throws DOMException if source is 0#1422

Merged
Juice10 merged 7 commits intorrweb-io:masterfrom
marandaneto:fix/createImageBitmap
Apr 5, 2024
Merged

fix: createImageBitmap throws DOMException if source is 0#1422
Juice10 merged 7 commits intorrweb-io:masterfrom
marandaneto:fix/createImageBitmap

Conversation

@marandaneto
Copy link
Contributor

Tries to fix #1421

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: d4bbe49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
rrweb Patch
rrweb-snapshot Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/types Patch
@rrweb/web-extension Patch
rrvideo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me...

@marandaneto marandaneto requested a review from p-mazhnik March 18, 2024 07:42
@marandaneto
Copy link
Contributor Author

@Juice10 can we merge this? just fixed the formatting issue, thanks for the patch though.

@Juice10
Copy link
Member

Juice10 commented Apr 5, 2024

@marandaneto if it passes CI (running now) I'll happily merge it

@marandaneto
Copy link
Contributor Author

@marandaneto if it passes CI (running now) I'll happily merge it

All happy and green :) thanks!

@Juice10 Juice10 merged commit 3d1877c into rrweb-io:master Apr 5, 2024
@Juice10
Copy link
Member

Juice10 commented Apr 5, 2024

@marandaneto done!

jaj1014 pushed a commit to pendo-io/rrweb that referenced this pull request Apr 30, 2024
)

* fix: createImageBitmap throws DOMException if source is 0

* code review

* fix

* Create breezy-cats-heal.md

* fix format

---------

Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Jul 31, 2024
)

* fix: createImageBitmap throws DOMException if source is 0

* code review

* fix

* Create breezy-cats-heal.md

* fix format

---------

Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Calling 'createImageBitmap' throws an exception

4 participants