Merged
Conversation
|
YunFeng0817
approved these changes
Jan 27, 2024
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
* run tests without concurrency * do not use cache in rpt2 during test
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 31, 2024
* run tests without concurrency * do not use cache in rpt2 during test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After investigating the current CI actions, there are two common errors in the failed test workflows:
Since we have many e2e tests running in puppeteer, and turbo parallel all the test tasks by default, it may cause a relatively large number of puppeteer instances in the CI env, which causes perf issues and makes the tests unstable.
So I set the concurrency of test tasks to 1.
For the rpt2 cache, I think it's because we have multiple
compileTSCodecalls in different test files, and jest also runs tests parallel by default.Instead of setting jest to disable concurrency, I change the
compileTSCodeto not use cache.These changes may slow down our test workflows but should make it work stable again. But I believe we can greatly improve test performance(also build performance) by enabling turbo cache in the CI env.