fix: console logger can serialize bigint values#1403
Merged
Juice10 merged 3 commits intorrweb-io:masterfrom Jan 25, 2024
PostHog:fix/serialize-big-int
Merged
fix: console logger can serialize bigint values#1403Juice10 merged 3 commits intorrweb-io:masterfrom PostHog:fix/serialize-big-int
Juice10 merged 3 commits intorrweb-io:masterfrom
PostHog:fix/serialize-big-int
Conversation
🦋 Changeset detectedLatest commit: f7eaf90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marandaneto
approved these changes
Jan 25, 2024
Contributor
Author
|
I don't think the failing tests are introduced in this PR 🙈 |
Juice10
approved these changes
Jan 25, 2024
This was referenced Jan 25, 2024
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
* fix: console logger can serialize bigint values * teach test jsdom is present * add a changeset
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 31, 2024
* fix: console logger can serialize bigint values * teach test jsdom is present * add a changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1209
console log record plugin already has a replacer function added to JSON.stringify call so we can add a handler for BigInt
when serializing
BigInt("1")before "TypeError: Do not know how to serialize a BigInt"
after '"1n"'