Skip to content

Make properties x and y optional in mouseInteractionParam#1375

Merged
Yuyz0112 merged 2 commits intorrweb-io:masterfrom
avillegasn:patch-1
Feb 10, 2024
Merged

Make properties x and y optional in mouseInteractionParam#1375
Yuyz0112 merged 2 commits intorrweb-io:masterfrom
avillegasn:patch-1

Conversation

@avillegasn
Copy link
Contributor

@avillegasn avillegasn commented Dec 14, 2023

The event representing a mouse interaction of focus an element does not include the properties x and y. Thus, they must be defined as optional.

Example of "focus" event without the x and y properties:

{
   "type": 3,
   "data": {
       "source": 2,
       "type": 5,
       "id": 408
    },
   "timestamp": 1702560401489
}

@avillegasn
Make properties x and y optional in mouseInteractionParam
5eba7ad 
The event representing a mouse interaction of focus an element does not include the properties x and y. Thus, they must be defined as optional.
@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1873ce7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Juice10
Copy link
Member

Juice10 commented Feb 5, 2024

Good catch! The fix does break some typing cases though, could you fix those then I can merge this PR?

@avillegasn
Copy link
Contributor Author

avillegasn commented Feb 9, 2024

Fixed!

@Yuyz0112 Yuyz0112 merged commit 5844f60 into rrweb-io:master Feb 10, 2024
@avillegasn avillegasn deleted the patch-1 branch February 12, 2024 10:00
@daibhin daibhin mentioned this pull request Apr 8, 2024
Merged
jaj1014 pushed a commit to pendo-io/rrweb that referenced this pull request Apr 30, 2024
@avillegasn
Make properties x and y optional in mouseInteractionParam (rrweb-io#1375
2cfbfd5 
)

* Make properties x and y optional in mouseInteractionParam

The event representing a mouse interaction of focus an element does not include the properties x and y. Thus, they must be defined as optional.

* Fix typings
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Jul 31, 2024
@avillegasn @jxiwang
Make properties x and y optional in mouseInteractionParam (rrweb-io#1375
d24237e 
)

* Make properties x and y optional in mouseInteractionParam

The event representing a mouse interaction of focus an element does not include the properties x and y. Thus, they must be defined as optional.

* Fix typings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yuyz0112 Yuyz0112 Yuyz0112 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avillegasn @Juice10 @Yuyz0112