Add "types" field to fix error when using "moduleResolution": "NodeNext"#1369
Merged
Juice10 merged 2 commits intorrweb-io:masterfrom Apr 18, 2024
stefansundin:fix-moduleResolution-nodenext
Merged
Add "types" field to fix error when using "moduleResolution": "NodeNext"#1369Juice10 merged 2 commits intorrweb-io:masterfrom stefansundin:fix-moduleResolution-nodenext
Juice10 merged 2 commits intorrweb-io:masterfrom
stefansundin:fix-moduleResolution-nodenext
Conversation
🦋 Changeset detectedLatest commit: 2d68597 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Any chance there's a maintainer that can take a look at this? Pretty please. 🥺 |
Juice10
approved these changes
Apr 18, 2024
Member
|
Thanks @stefansundin, this PR #1033 is also on the horizon which also fixes this. But I'm more then happy to get your version shipped asap |
This was referenced Apr 18, 2024
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 26, 2024
…xt" (rrweb-io#1369) * Add "types" field to fix error when using "moduleResolution": "NodeNext". * Add changeset.
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 26, 2024
…xt" (rrweb-io#1369) * Add "types" field to fix error when using "moduleResolution": "NodeNext". * Add changeset.
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
…xt" (rrweb-io#1369) * Add "types" field to fix error when using "moduleResolution": "NodeNext". * Add changeset.
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 31, 2024
…xt" (rrweb-io#1369) * Add "types" field to fix error when using "moduleResolution": "NodeNext". * Add changeset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
In my project I am attempting to use
"moduleResolution": "NodeNext"in mytsconfig.jsonfile, and importing rrweb types like this:But it results in this error:
After searching online and testing a few things, making the change in this PR made the error go away.
Please let me know if you want any other changes. Thanks!