Skip to content

Enable preserveSource of rollup-plugin-web-worker-loader#1309

Merged
eoghanmurray merged 1 commit intorrweb-io:masterfrom
KentoMoriwaki:kento/preserveSource
Oct 6, 2023
Merged

Enable preserveSource of rollup-plugin-web-worker-loader#1309
eoghanmurray merged 1 commit intorrweb-io:masterfrom
KentoMoriwaki:kento/preserveSource

Conversation

@KentoMoriwaki
Copy link
Contributor

@KentoMoriwaki KentoMoriwaki commented Sep 23, 2023

Ref: #1308

This change modifies the build output `` as detailed below:

Before

var WorkerFactory = createBase64WorkerFactory('Lyogcm9sbHVwLXBsdWdpbi13Z...', null, false);

After

var WorkerFactory = createInlineWorkerFactory(/* rollup-plugin-web-worker-loader */function () {
(function () {
    '__worker_loader_strict__';

   --- SOURCE CODE HERE ---

})();
}, null);

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2023

⚠️ No Changeset found

Latest commit: 7a49068

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KentoMoriwaki
Copy link
Contributor Author

KentoMoriwaki commented Sep 23, 2023

I tried using this build locally to record canvas, but it did not work correctly (the initial drawing is saved, but the modifications are not).
Interestingly, when I disabled minification in Vite for my application, the canvas recording functioned correctly.

It seems this change has the potential to break existing applications, and it might be necessary to alert users to modify their settings accordingly.

eoghanmurray
eoghanmurray approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@eoghanmurray eoghanmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per Justin, it wasn't deliberate that it was base64 encoded

@eoghanmurray eoghanmurray merged commit 297104c into rrweb-io:master Oct 6, 2023
billyvg pushed a commit to getsentry/rrweb that referenced this pull request Oct 20, 2023
@KentoMoriwaki @billyvg
Enable preserveSource (rrweb-io#1309)
1e512df
@daibhin
Copy link
Contributor

daibhin commented Apr 11, 2024

Can confirm that this is breaking in production since upgrading recently

This was referenced Apr 12, 2024
Open
Merged
billyvg added a commit to getsentry/rrweb that referenced this pull request Apr 26, 2024
@billyvg
Revert "Enable preserveSource (rrweb-io#1309)"
fdf0ade 
This reverts commit 297104c.
@daibhin daibhin mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eoghanmurray eoghanmurray eoghanmurray approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KentoMoriwaki @daibhin @eoghanmurray