feat: Added support maskInputFn with HTMLElement#1188
Merged
Juice10 merged 6 commits intorrweb-io:masterfrom Apr 15, 2023
PostHog:feat/mask-fn-input
Merged
feat: Added support maskInputFn with HTMLElement#1188Juice10 merged 6 commits intorrweb-io:masterfrom PostHog:feat/mask-fn-input
Juice10 merged 6 commits intorrweb-io:masterfrom
PostHog:feat/mask-fn-input
Conversation
🦋 Changeset detectedLatest commit: 6b583e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@Juice10 don't want to bother but what would be the best way to get attention for PRs that are good to go? |
Juice10
approved these changes
Apr 15, 2023
Member
|
@benjackwhite Thanks for submitting this PR. At the moment we go through all the open pull requests once a month as a team, or ourselves whenever we have time. We're hoping to attract some more sponsorship for the project which will allow us to free up some more time to do this more often. |
YunFeng0817
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Apr 16, 2023
This was referenced Jul 6, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 3, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commonly people want to have the safety of knowing all inputs are masked but also the ability to selectively unmask (perhaps for a search box for example).
This PR extends the
MaskInputFnto have a second argument which is theHTMLElement. This way users can easily define their own logic to decide whether the input should be masked or not.