fix: Explicitly handle null attribute values#1157
Merged
YunFeng0817 merged 4 commits intorrweb-io:masterfrom Feb 27, 2023
Merged
fix: Explicitly handle null attribute values#1157YunFeng0817 merged 4 commits intorrweb-io:masterfrom
null attribute values#1157YunFeng0817 merged 4 commits intorrweb-io:masterfrom
Conversation
The attribute `value` can be null when a mutation observer triggers due to a removed attribute. This is currently not reflected by types and code.
🦋 Changeset detectedLatest commit: b242c56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
YunFeng0817
approved these changes
Feb 27, 2023
Member
YunFeng0817
left a comment
There was a problem hiding this comment.
Great catch! Thanks for your contribution.
This was referenced Jul 6, 2023
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Nov 11, 2023
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an attribute is removed via
el.removeAttribute('my-attr'), this triggers the mutation observer with anullvalue for the attribute. This is currently not handled by the code/types.This PR adjusts this to handle this case explicitly.