Skip to content

Security rule deprecated#2

Merged
till merged 1 commit intomasterfrom
unknown repository
May 9, 2012
Merged

Security rule deprecated#2
till merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 9, 2012

Since roundcube switched to git, maybe security rules should forbid .git/ directory instead of .svn/ isn't it ?

@Brianetta
Copy link
Copy Markdown

It might be an idea to disallow them both.

till added a commit that referenced this pull request May 9, 2012
Security rule deprecated
@till till merged commit 610b6a3 into roundcube:master May 9, 2012
@till
Copy link
Copy Markdown
Contributor

till commented May 9, 2012

@Brianetta Feel free to send another PR.

bostjan added a commit to bostjan/roundcubemail that referenced this pull request Apr 14, 2016
…_insert' actual search and result data

Reason:
In order to enable development of sophisticated autocomplete algorithms, they will need
to process all the data relevant to autocomplete - what was the search string and which
result was the correct one.

Example to illustrate the need:
Say we are talking about these two people of interest, who are in the address book, among others:
- person 1: Bostjan Skufca <bostjan@a2o.si>
- person 2: Bostjan SkuBIC <bostjan@otherdomain.com>

Our user is used to think about the first person by the first name, "Bostjan", as he is an old friend.
The second one is a colleague at work where people call themselves mostly by surnames, "Skubic" in this case.

Without this data provided to 'autocomplete_insert', there is no way for RC to learn that when our user
enters "bos" in the To: field he thinks about person #1 (Bostjan SkuFCA), and when he starts typing "sku"
he means person roundcube#2 (Bostjan SkuBIC).
@PetrJakes PetrJakes mentioned this pull request May 29, 2019
@be-root be-root mentioned this pull request Mar 24, 2021
@alxbr alxbr mentioned this pull request Dec 12, 2021
WinniW31 pushed a commit to WinniW31/roundcubemail-eai-login-thnicf that referenced this pull request Mar 14, 2022
@amend07 amend07 mentioned this pull request Jun 6, 2024
2 tasks
@dsvf dsvf mentioned this pull request Aug 17, 2025
2 tasks
@wdsnyc wdsnyc mentioned this pull request Nov 28, 2025
@joksik joksik mentioned this pull request Feb 27, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants