add cookie path config option and use settings for js cookies#10
Closed
johndoh wants to merge 2 commits intoroundcube:masterfrom
johndoh:master
Closed
add cookie path config option and use settings for js cookies#10johndoh wants to merge 2 commits intoroundcube:masterfrom johndoh:master
johndoh wants to merge 2 commits intoroundcube:masterfrom
johndoh:master
Conversation
Member
There was a problem hiding this comment.
Maybe add ini_get('session.cookie_domain') as default value to get()
Member
|
TinyMCE also uses cookies, but we don't want to modify their code. We should ask them for changes. |
Contributor
Author
|
the tinymce cookie code is never used by rc. its only called in 2 places: tiny_mce/plugins/paste/editor_plugin.js, tiny_mce/themes/advanced/editor_template.js. In both cases the functions are never called because of the settings used by rc. for completeness the cookie options should still be set in tinymce so that if someone extends rc in a way that uses them in it will work but since it is not part of the core i'm not sure it needs to hold up development. |
Member
|
Implemented in ae7027d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a config optioni to allow the setting for the cookie path. the domain and secure optoins are already configurable, path is the only option not current covered.
some cookies are also created by javascript, positions of splitter bars etc. they should also use the cookie options defined in the main config file