[galactic] Export YAML_CPP_DLL define on Windows#31
Closed
Ace314159 wants to merge 2 commits intoros2:galacticfrom
Closed
[galactic] Export YAML_CPP_DLL define on Windows#31Ace314159 wants to merge 2 commits intoros2:galacticfrom
Ace314159 wants to merge 2 commits intoros2:galacticfrom
Conversation
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
Contributor
|
While this is the right thing to do, it also means that we need to "undo" all of the places where we hard-coded YAML_CPP_DLL before. That's why the Windows CI build is yellow. |
Contributor
Author
|
I can make PRs to do that. I have made: |
Member
|
Holding this PR until the related PRs are merged so we can get green Windows CI. |
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
Member
|
Let's try some CI!
|
|
Closing this out since Galactic is EOL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10