Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Port upstream PRs 111 and 112 addressing linker warning#11

Merged
dirk-thomas merged 2 commits intoros2from
port_111_112
May 1, 2018
Merged

Port upstream PRs 111 and 112 addressing linker warning#11
dirk-thomas merged 2 commits intoros2from
port_111_112

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas commented May 1, 2018

Replaces #10.

Port of ros#111 and ros#112 addressing a linker warning.

CI builds up to urdf_parser:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Packaging build on macOS: Build Status (https://ci.ros2.org/job/ci_packaging_osx/32/consoleFull#console-section-172)

* skip test directory when building tests is not requested

* include CTest
@dirk-thomas dirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) labels May 1, 2018
@dirk-thomas dirk-thomas self-assigned this May 1, 2018
@dirk-thomas dirk-thomas added bug Something isn't working and removed enhancement New feature or request labels May 1, 2018
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once packaging job comes back happy (without the warning in the console output)

@dirk-thomas
Copy link
Copy Markdown
Member Author

without the warning in the console output

It has already passed that point - see the link to the console output and the section "urdfdom (stderr)".

@mikaelarguedas
Copy link
Copy Markdown
Member

👍

For future reference: pointing to sections in consoleFull doesnt work if the section is not among the first ones to be loaded.

Confirmed that the warning from the nightlies: "ld: warning: directory not found for option" doesnt show up in the packaging job linked above. 🚢

@dirk-thomas
Copy link
Copy Markdown
Member Author

For future reference: pointing to sections in consoleFull doesnt work if the section is not among the first ones to be loaded.

You can change the anchor to something else and back and then you are at the desired location.

@mikaelarguedas
Copy link
Copy Markdown
Member

You can change the anchor to something else and back and then you are at the desired location.

Yeah manually changing the URL twice will work..

@dirk-thomas dirk-thomas merged commit 1ac9141 into ros2 May 1, 2018
@dirk-thomas dirk-thomas deleted the port_111_112 branch May 1, 2018 18:50
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants