This patch only addresses the library warning. It doesn't address the fact that the package performs test specific steps (building gtest, removing test results, etc.) when testing is explicitly disabled.

Is there a reason for not putting all the test stuff in that if(BUILD_TESTING) as well ?

Is there a reason for not putting all the test stuff in that if(BUILD_TESTING) as well ?

The patch simply addresses the warning I notices. I just don't have more time to spend on it.

Skipping the test directory all together: https://ci.ros2.org/view/colcon/job/colcon_ci_packaging_osx/9/consoleFull#console-section-175

Filed upstream: ros#111

upstream patch has been merged.
CI is happy (false positive on the cmake warning)

Does including CTest again has any side effect ?

I have updated this PR to contain the commit merged upstream.

Does including CTest again has any side effect ?

I would assume no but I have certainly not tested that any further.

Unfortunately this doesn't fix the linker warning anymore: https://ci.ros2.org/view/colcon/job/colcon_ci_packaging_osx/11/consoleFull#console-section-172

@scpeters the modified patch doesn't fix the linker warning anymore. Can you maybe look into this and propose a different fix?

@dirk-thomas what is the status on this ? We should cherry-pick ros#112 and be good to go ?

See #11.