add a test which uses the create_subscription with queue size api#56
Merged
add a test which uses the create_subscription with queue size api#56
Conversation
This was referenced Oct 14, 2015
Member
|
Does this test have to replicate the whole testing with spin etc. or is it sufficient to only check the signature to create a subscription with a queue size? |
Member
Author
|
Well, I figure it was worth making sure a subscription created with this API would result in a functioning subscription, but I can slim the test down further if you don't think that's important. |
Member
|
Related to my other comment (ros2/rclcpp#128 (comment)) I would think testing the functionality of the core functionality is enough. For the syntactic sugar API a simple test checking that a specific signature works would be enough. |
Member
Author
|
Ok I simplified the test to just creating a subscription. The tests passed locally, so I won't run another CI. |
Member
|
+1 |
Member
|
lgtm |
wjwwood
added a commit
that referenced
this pull request
Oct 14, 2015
add a test which uses the create_subscription with queue size api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/design#56.