Skip to content

chore: Adopted to API changes in rclcpp#556

Merged
ahcorde merged 1 commit intoros2:rollingfrom
jmachowinski:expose_waitable_timers
Jan 30, 2025
Merged

chore: Adopted to API changes in rclcpp#556
ahcorde merged 1 commit intoros2:rollingfrom
jmachowinski:expose_waitable_timers

Conversation

@jmachowinski
Copy link
Copy Markdown
Contributor

@jmachowinski jmachowinski commented Jan 28, 2025

This was referenced Jan 28, 2025
Merged
Merged
@jmachowinski
Copy link
Copy Markdown
Contributor Author

jmachowinski commented Jan 28, 2025

Pulls: ros2/rclcpp#2699, #556, ros2/rcl#1201
Gist: https://gist.githubusercontent.com/jmachowinski/711b3e342bed5cd8c16b1b4cffd6c361/raw/22af95b0a7ea9789dfda5280fe2b51d84965a9de/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15101

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes Jan 28, 2025
View reviewed changes
@jmachowinski
Copy link
Copy Markdown
Contributor Author

jmachowinski commented Jan 28, 2025

Pulls: ros2/rclcpp#2699, #556, ros2/rcl#1201
Gist: https://gist.githubusercontent.com/jmachowinski/7608e9da50fcb66b359b3a37b7a301b4/raw/22af95b0a7ea9789dfda5280fe2b51d84965a9de/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15102

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

chore: Adopted to API changes in rclcpp
f029008 
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
@jmachowinski jmachowinski force-pushed the expose_waitable_timers branch from 4758255 to f029008 Compare January 29, 2025 10:01
@jmachowinski
Copy link
Copy Markdown
Contributor Author

jmachowinski commented Jan 29, 2025 •
edited
Loading

Pulls: ros2/rclcpp#2699, #556, ros2/rcl#1201
Gist: https://gist.githubusercontent.com/jmachowinski/d0c0fd4939d4c2a8515d3e7c6039c009/raw/22af95b0a7ea9789dfda5280fe2b51d84965a9de/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15105

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

christophebedard
christophebedard approved these changes Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Jan 29, 2025

Looks like the Windows job failure is a flake and could just be retriggered.

@jmachowinski
Copy link
Copy Markdown
Contributor Author

jmachowinski commented Jan 29, 2025

I already re triggered it twice... The current job looks like it is going to pass.

@ahcorde ahcorde merged commit 95805d2 into ros2:rolling Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@christophebedard christophebedard christophebedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmachowinski @christophebedard @ahcorde