adding tests for intra process communications#28
Merged
Conversation
4 tasks
Contributor
|
Are you going to test the case of multiple nodes with intra-process enabled here, or the case of 1 node with intra-process enabled and 1 with intra-process disabled? |
Member
Author
|
Yes.... Let's push those for round 2 where I actually implement subscription filtering because this test is horribly naive as is. So as most this test is testing that it just works in the best scenario. I'll add a note on ros2/ros2#91 so we don't forget: ros2/ros2#91 (comment) |
Contributor
|
Sounds good. |
Member
Author
|
I should say this test is horribly naive as is because there is no subscription filtering. Anything more complex would likely break. |
Member
|
+1 |
wjwwood
added a commit
that referenced
this pull request
Aug 21, 2015
adding tests for intra process communications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/ros2#59