Merged
Conversation
ROS 2 tests are limited by the version of packages available in Ubuntu Bionic, not the ones available in pip. As a result, we need to make sure we only take advantage of the features as of pytest v3.3.2. A side effect of this is that we must use `tmpdir_factory` as opposed to `tmp_path_factory`, which wasn't introduced until v4.3.0. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Member
Author
|
Can someone with power please manually trigger a CI job using http://build.ros2.org/view/Eci/job/Eci__overlay_ubuntu_bionic_amd64/ ? |
Member
|
Before: |
Member
|
And the usual CI (using the |
Member
|
Thanks for the quick patch. |
ruffsl
pushed a commit
to ruffsl/sros2
that referenced
this pull request
Aug 6, 2019
ROS 2 tests are limited by the version of packages available in Ubuntu Bionic, not the ones available in pip. As a result, we need to make sure we only take advantage of the features as of pytest v3.3.2. A side effect of this is that we must use `tmpdir_factory` as opposed to `tmp_path_factory`, which wasn't introduced until v4.3.0. Signed-off-by: Kyle Fazzari <kyle@canonical.com> Signed-off-by: ruffsl <roxfoxpox@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROS 2 tests are limited by the version of packages available in Ubuntu Bionic, not the ones available in pip. As a result, we need to make sure we only take advantage of the features as of pytest v3.3.2. A side effect of this is that we must use
tmpdir_factoryas opposed totmp_path_factory, which wasn't introduced until v4.3.0.