Add tests for generate_policy verb#122
Merged
jacobperron merged 3 commits intoros2:masterfrom Jun 12, 2019
Merged
Conversation
The verbs are missing tests. Let's get started by adding some basic coverage to `generate_policy`. Also ensure that `generate_policy` abides by established conventions, returning 0 upon success. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
jacobperron
reviewed
Jun 12, 2019
Member
jacobperron
left a comment
There was a problem hiding this comment.
LGTM. Just a couple minor comments.
Thanks!
sros2/test/sros2/commands/security/verbs/test_generate_policy.py
Outdated
Show resolved
Hide resolved
sros2/test/sros2/commands/security/verbs/test_generate_policy.py
Outdated
Show resolved
Hide resolved
jacobperron
reviewed
Jun 12, 2019
sros2/test/sros2/commands/security/verbs/test_generate_policy.py
Outdated
Show resolved
Hide resolved
Also use `1` instead of QoSProfile. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Member
Edit: Rebuild after 8a662ba |
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Member
ruffsl
pushed a commit
to ruffsl/sros2
that referenced
this pull request
Aug 6, 2019
* Add tests for generate_policy verb The verbs are missing tests. Let's get started by adding some basic coverage to `generate_policy`. Also ensure that `generate_policy` abides by established conventions, returning 0 upon success. Signed-off-by: Kyle Fazzari <kyle@canonical.com> * Add std_msgs as a test_depend Also use `1` instead of QoSProfile. Signed-off-by: Kyle Fazzari <kyle@canonical.com> * Reorder imports Signed-off-by: Kyle Fazzari <kyle@canonical.com> Signed-off-by: ruffsl <roxfoxpox@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verbs are missing tests. Let's get started by adding some basic coverage to
generate_policy. Also ensure thatgenerate_policyabides by established conventions, returning 0 upon success.