Merged
Conversation
Contributor
Author
Merged
91f701a to
fd34810
Compare
Contributor
Author
fd34810 to
d5ad808
Compare
Contributor
Author
d5ad808 to
29937aa
Compare
Contributor
Author
29937aa to
e8eaab9
Compare
Contributor
Author
e8eaab9 to
9d21bb4
Compare
Contributor
5997b63 to
5872a16
Compare
9d21bb4 to
7fc270e
Compare
Contributor
Author
|
What's going to happen with this PR? Shall I try to look a bit deeper or do we just wait for the release (I'm going to postpone new CIs for now). |
wjwwood
approved these changes
Dec 20, 2018
wjwwood
added a commit
that referenced
this pull request
Dec 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes symbols of all classes. This is necessary when subclassing. Since warnings are being thrown on Windows, those are disabled by pragmas.
Here is my understanding on when this is safe:
std- Microsoft itself says warnings can be ignored at that point, see https://msdn.microsoft.com/library/esew7y1w.aspx).It will only ever be problematic when a client derives from this class.
In our case, this implies it's mostly safe to set pragmas. The only problem I can see happening is when a client derives from e.g.
MarkerBaseand uses a different version ofvisualization_msgs::msg::Marker::ConstSharedPtrorrclcpp::Time. But I don't see how this can be done without breaking the ROS installation even earlier. To be sure, I added a comment explaining what's happening if ever somebody encounters a problem.