Conversation
Member
|
While #234 was definitely a bug (used something that was not depended on), I don't consider this a bug in this package. However, it is a bug that will come up again and again. The only place it could be fixed is with a cmake function that orders the headers based on the workspaces order. |
mikaelarguedas
added a commit
that referenced
this pull request
Apr 12, 2018
This reverts commit e4837c8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar as #234. This was broken again by #186.
This is only a hack to get the build passing again (when
urdfis installed on the system and the headers are found in/usr/include).This needs a real fix and the use case should be tested for before future PRs are being merged. @mikaelarguedas already mentioned that in his PR.