This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…anguage support Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
dirk-thomas
approved these changes
May 19, 2020
jacobperron
approved these changes
May 19, 2020
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes osrf/docker_images#403.
We use Connext Module with two different purposes:
In the first case, variables like
Connext_GLIBCXX_USE_CXX11_ABI_ZEROaren't of interest.This PR does two changes:
Connext_GLIBCXX_USE_CXX11_ABI_ZEROif the project that find-pkged Connext Module doesn't have CXX language support (in that case, settingConnext_GLIBCXX_USE_CXX11_ABI_ZEROis for sure not of interest).