Prototype code for seeing if FindPython3 is usable for rosidl_python#140
Merged
clalancette merged 10 commits intorollingfrom Feb 11, 2024
Merged
Prototype code for seeing if FindPython3 is usable for rosidl_python#140clalancette merged 10 commits intorollingfrom
clalancette merged 10 commits intorollingfrom
Conversation
Contributor
Author
|
Full CI with build type None
Full CI with build type Release
Not doing Debug, because I would expect this to fail on windows as it's currently written |
Contributor
Author
|
Full CI with build type None
|
c73fd47 to
42df4d9
Compare
Member
|
@sloretz I'm curious what were the issues with this, do you remember? |
42df4d9 to
191a804
Compare
5351042 to
a899bf7
Compare
6ec3578 to
1b18ac0
Compare
Contributor
|
CI for this is over in ros2/python_cmake_module#7 (comment) |
sloretz
commented
Jan 5, 2024
rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
sloretz
commented
Jan 5, 2024
rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
sloretz
commented
Jan 24, 2024
sloretz
commented
Jan 24, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
In the first stage, we just find the interpreter. For the second stage, we use the debug interpreter as necessary to find NumPy. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
b195abb to
4b6622e
Compare
python_cmake_module is now only exporting that. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
approved these changes
Feb 11, 2024
Contributor
|
CI for this is over in ros2/python_cmake_module#7 (comment) |
Closed
wentasah
added a commit
to wentasah/nix-ros-overlay
that referenced
this pull request
Aug 8, 2024
The patched code was removed in ros2/rosidl_python#140.
wentasah
added a commit
to wentasah/nix-ros-overlay
that referenced
this pull request
Aug 8, 2024
The patched code was removed in ros2/rosidl_python#140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prototype intended to see how usable FindPython3 on non-linux platforms is.
rosidl_generator_pymakes the most use ofFindPythonExtra.Should inform ros2/python_cmake_module#7