change generator to IDL-based pipeline#47
Merged
dirk-thomas merged 38 commits intomasterfrom Mar 12, 2019
Merged
Conversation
dirk-thomas
reviewed
Dec 5, 2018
Member
|
@jacobperron Can you review this please? I can't select you as a reviewer though since you created the first version of the PR. |
Member
Author
👍 |
jacobperron
commented
Feb 21, 2019
Member
Author
jacobperron
left a comment
There was a problem hiding this comment.
LGTM, though I did contribute some of the changes (I think the parts I commented on were introduced by me 😆).
Co-Authored-By: dirk-thomas <dirk-thomas@users.noreply.github.com>
Co-Authored-By: dirk-thomas <dirk-thomas@users.noreply.github.com>
jacobperron
commented
Feb 22, 2019
Member
Author
jacobperron
left a comment
There was a problem hiding this comment.
LGTM, but I am unable to approve my own PR.
dirk-thomas
approved these changes
Feb 22, 2019
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
Representing the 👍 from @jacobperron.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved from #46
Connects to ros2/rosidl#334