Expose .msg/.srv/.action to .idl conversion via rosidl translate CLI#576
Merged
Expose .msg/.srv/.action to .idl conversion via rosidl translate CLI#576
Conversation
26e2bd0 to
38748ff
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
91e5152 to
014e218
Compare
Contributor
Author
|
CI up to
|
sloretz
reviewed
Mar 8, 2021
Contributor
sloretz
left a comment
There was a problem hiding this comment.
LGTM with a couple nitpicks and windows CI made happy
rosidl_adapter/rosidl_adapter/cli.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2018 Open Source Robotics Foundation, Inc. | |||
| # Copyright 2018-2021 Open Source Robotics Foundation, Inc. | |||
Contributor
There was a problem hiding this comment.
No need to update the copyright year. I'm pretty sure we don't usually bump it.
Contributor
Author
There was a problem hiding this comment.
I've seen both, but I don't mind strongly. Reverted in 74e0044.
rosidl_adapter/rosidl_adapter/cli.py
Outdated
|
|
||
| @property | ||
| def conversion_function(self): | ||
| from rosidl_adapter.msg import convert_msg_to_idl |
Contributor
There was a problem hiding this comment.
Why is the import in the function instead of on the module?
Contributor
Author
There was a problem hiding this comment.
This source file didn't import them directly, so I just went with it. But I don't mind strongly. Moved to the top in 74e0044.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Contributor
Author
|
Re-running Windows CI after 2775f03:
|
ahcorde
approved these changes
Mar 9, 2021
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Contributor
Author
|
Re-running Windows CI after 928c1a4:
|
Contributor
Author
|
And again, using ament/ament_cmake#327:
|
Contributor
Author
|
CI's green and ament/ament_cmake#327 is merged. Going in ! |
MichaelOrlov
pushed a commit
to MichaelOrlov/rosidl
that referenced
this pull request
May 24, 2023
- Fix for ""// with input from rosbag2_storage_mcap_testdata/msg\\ComplexMsgDependsOnIdl.msg" - On Windows platform message generator messing up with the input file name ""/msg\\ComplexMsgDependsOnIdl.msg" by inserting double backslashes instead of one forward slash. - Partial backport from ros2#576 Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to #565. Depends on #575.